Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "flyingcomponents" special world property #3597

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

FileEX
Copy link
Contributor

@FileEX FileEX commented Jul 22, 2024

Merge after #3572

This PR adds a new special world property called flyingcomponents (default is true). This property determines whether the detached components such as doors, bumpers, etc., should respawn after a vehicle is recreated or streamed in. This PR solves a very frustrating and annoying issue where all missing components fall off again after using setElementModel or setVehicleVariant:

image

Thanks to this property, various car garages and vehicle spawners will be able to look normal without flying components around

flyingcomponents special world property
@Dark-Dragon
Copy link
Contributor

Again I'll have to point out that this to me seems like more of a bug-fix-scenario, rather than a special-world-property-scenario. What about the current behavior is desirable?

@FileEX
Copy link
Contributor Author

FileEX commented Jul 22, 2024

Probably nothing, but it's better to set it to the current default than for the PR to get labeled as 'backwards-incompatible' and end up stalled for several months, or possibly even years

@tederis tederis added the enhancement New feature or request label Jul 22, 2024
@TheNormalnij
Copy link
Member

Probably nothing, but it's better to set it to the current default than for the PR to get labeled as 'backwards-incompatible'

It won't. Current state is bugged

@FileEX
Copy link
Contributor Author

FileEX commented Oct 5, 2024

Probably nothing, but it's better to set it to the current default than for the PR to get labeled as 'backwards-incompatible'

It won't. Current state is bugged

Done

Copy link
Contributor

@Fernando-A-Rocha Fernando-A-Rocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants