-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for hashing from a reader #159
Open
Stebalien
wants to merge
8
commits into
feat/no-digest
Choose a base branch
from
feat/digest-reader
base: feat/no-digest
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Nov 8, 2021
-
Remove the per-hasher digest type. Instead, store hash digests inside the hashers and "borrow" it. In all cases, we're going to copy it into a `Multihash<S>` anyways. This: 1. Removes bunch of code. 2. Means that hashers don't need to be generic over the size (unless they actually support multiple sizes). This fixes the UX issue introduced in the const generics PR. 3. Avoids some copying. BREAKING CHANGE 1. `Hasher.digest` no longer exists. Users should use `Code::SomeCode.digest` where possible. 2. The hasher digests no longer exist.
Configuration menu - View commit details
-
Copy full SHA for 0c0eb11 - Browse repository at this point
Copy the full SHA 0c0eb11View commit details
Commits on Nov 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 184ed59 - Browse repository at this point
Copy the full SHA 184ed59View commit details -
Configuration menu - View commit details
-
Copy full SHA for f002173 - Browse repository at this point
Copy the full SHA f002173View commit details
Commits on Jan 27, 2022
-
Use config flags instead of introducing the new attribute `io_path`.
Configuration menu - View commit details
-
Copy full SHA for fe59061 - Browse repository at this point
Copy the full SHA fe59061View commit details -
fix: use compile-time asserts to guards unwraps
With some compile-time asserts we can make sure that certain `unwrap()` calls won't panic.
Configuration menu - View commit details
-
Copy full SHA for ec8cc76 - Browse repository at this point
Copy the full SHA ec8cc76View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1a6943 - Browse repository at this point
Copy the full SHA e1a6943View commit details -
Configuration menu - View commit details
-
Copy full SHA for 095f19c - Browse repository at this point
Copy the full SHA 095f19cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 868dab7 - Browse repository at this point
Copy the full SHA 868dab7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.