feat: into_v1 #121
Merged
feat: into_v1 #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmx
reviewed
Aug 4, 2022
src/cid.rs
Outdated
| @@ -108,6 +108,19 @@ impl<const S: usize> Cid<S> { | |||
| } | |||
| } | |||
|
|
|||
| /// Convert a CIDv0 to a CIDv1 | |||
There was a problem hiding this comment.
Nitpick (change will be approved and merge even without changing it): Perhaps adding information that if it is already a CIDv1, that it will be unchanged.
There was a problem hiding this comment.
I literally wrote it out, thought it was a bit verbose compared to the others and dropped it. Also test incoming :)
vmx
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple conversion based on what other implementations do.
Should also help move #59 along.