Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce org owners/admins #85

Merged
merged 4 commits into from
Feb 14, 2024
Merged

Reduce org owners/admins #85

merged 4 commits into from
Feb 14, 2024

Conversation

BigLep
Copy link
Contributor

@BigLep BigLep commented Feb 13, 2024

Summary

This aligns with the "reduce org owners" step listed in ipfs/ipfs#511.

This is the first step of wider 2024Q1 permissions cleanup.

This is matching IPLD for now: ipld/github-mgmt#68

Why do you need this?

Github org safety. See ipfs/ipfs#511 for more info.

Timeline

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@BigLep BigLep self-assigned this Feb 13, 2024
@BigLep BigLep requested review from a team as code owners February 13, 2024 01:17
@BigLep BigLep changed the title Update multiformats.yml - reduce org owners/admins Reduce org owners/admins Feb 13, 2024
Copy link
Contributor

github-actions bot commented Feb 13, 2024

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

multiformats

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place
  - destroy

Terraform will perform the following actions:

  # github_membership.this["daviddias"] will be updated in-place
  ~ resource "github_membership" "this" {
        id       = "multiformats:daviddias"
      ~ role     = "admin" -> "member"
        # (2 unchanged attributes hidden)
    }

  # github_membership.this["jbenet"] will be updated in-place
  ~ resource "github_membership" "this" {
        id       = "multiformats:jbenet"
      ~ role     = "admin" -> "member"
        # (2 unchanged attributes hidden)
    }

  # github_membership.this["kubuxu"] will be updated in-place
  ~ resource "github_membership" "this" {
        id       = "multiformats:Kubuxu"
      ~ role     = "admin" -> "member"
        # (2 unchanged attributes hidden)
    }

  # github_membership.this["marten-seemann"] will be updated in-place
  ~ resource "github_membership" "this" {
        id       = "multiformats:marten-seemann"
      ~ role     = "admin" -> "member"
        # (2 unchanged attributes hidden)
    }

  # github_membership.this["raulk"] will be updated in-place
  ~ resource "github_membership" "this" {
        id       = "multiformats:raulk"
      ~ role     = "admin" -> "member"
        # (2 unchanged attributes hidden)
    }

  # github_membership.this["stebalien"] will be updated in-place
  ~ resource "github_membership" "this" {
        id       = "multiformats:Stebalien"
      ~ role     = "admin" -> "member"
        # (2 unchanged attributes hidden)
    }

  # github_membership.this["whyrusleeping"] will be updated in-place
  ~ resource "github_membership" "this" {
        id       = "multiformats:whyrusleeping"
      ~ role     = "admin" -> "member"
        # (2 unchanged attributes hidden)
    }

  # github_repository_collaborator.this["github-mgmt:galargh"] will be destroyed
  # (because key ["github-mgmt:galargh"] is not in for_each map)
  - resource "github_repository_collaborator" "this" {
      - id         = "github-mgmt:galargh" -> null
      - permission = "admin" -> null
      - repository = "github-mgmt" -> null
      - username   = "galargh" -> null
    }

  # github_team_membership.this["github-mgmt stewards:achingbrain"] will be updated in-place
  ~ resource "github_team_membership" "this" {
        id       = "6630975:achingbrain"
      ~ role     = "maintainer" -> "member"
        # (3 unchanged attributes hidden)
    }

  # github_team_membership.this["github-mgmt stewards:aschmahmann"] will be updated in-place
  ~ resource "github_team_membership" "this" {
        id       = "6630975:aschmahmann"
      ~ role     = "maintainer" -> "member"
        # (3 unchanged attributes hidden)
    }

  # github_team_membership.this["github-mgmt stewards:biglep"] will be destroyed
  # (because key ["github-mgmt stewards:biglep"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"f3bf5b87deb2a55bc2cbbbfcad0370bc440bdd847c58ad24bcbba11f4d00d997\"" -> null
      - id       = "6630975:BigLep" -> null
      - role     = "member" -> null
      - team_id  = "6630975" -> null
      - username = "BigLep" -> null
    }

  # github_team_membership.this["github-mgmt stewards:lidel"] will be destroyed
  # (because key ["github-mgmt stewards:lidel"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"9c6ebea9c1b95091517194593ec2339b12eebbf4adb2bd3f42a42f097a04c5dc\"" -> null
      - id       = "6630975:lidel" -> null
      - role     = "member" -> null
      - team_id  = "6630975" -> null
      - username = "lidel" -> null
    }

  # github_team_membership.this["github-mgmt stewards:rvagg"] will be updated in-place
  ~ resource "github_team_membership" "this" {
        id       = "6630975:rvagg"
      ~ role     = "maintainer" -> "member"
        # (3 unchanged attributes hidden)
    }

  # github_team_membership.this["github-mgmt stewards:vmx"] will be updated in-place
  ~ resource "github_team_membership" "this" {
        id       = "6630975:vmx"
      ~ role     = "maintainer" -> "member"
        # (3 unchanged attributes hidden)
    }

Plan: 0 to add, 11 to change, 3 to destroy.

@BigLep
Copy link
Contributor Author

BigLep commented Feb 13, 2024

@daviddias
@jbenet
@Kubuxu
@lidel
@marten-seemann
@raulk
@Stebalien
@whyrusleeping

I'm @mentioning you to inform you that your ipfs github "org ownership" permissions are being removed as part of a ipfs/ipfs#511. You are still a member of the ipfs github org and retain your existing direct github repo permissions or team permissions.

The current plan is to merge this change on Wednesday, 2024-02-14.

That said, this isn't a one-way door. If we got this wrong or you see the notification after the fact, a new PR can be created fix permissions.

Thanks and let me know if you have any questions or concerns.

@BigLep BigLep merged commit 0d23097 into master Feb 14, 2024
6 checks passed
@BigLep BigLep deleted the biglep-reduce-org-owners-2024q1 branch February 14, 2024 20:56
@BigLep BigLep mentioned this pull request Feb 16, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants