Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W-17291697 Enforcer require plugin versions to be defined #247

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

W-17291697 Enforcer require plugin versions to be defined #247

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
daa74c6
Update pom.xml
helfgott Nov 28, 2024
cbfe497
Update pom.xml
helfgott Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,7 @@
<plugin>
<groupId>org.mule.tools.maven</groupId>
<artifactId>mule-module-maven-plugin</artifactId>
<version>${project.version}</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should use the verison of the dep in place of the project version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm the parent of hte pom is mule-plugin-mgmt-parent-pom. Check if the plugin is defined in the plugin mangement section of the mule-plugin-mgmt-parent-pom. In that case as it is already defined in the parent it shouldn't fail the enforcer.

Copy link
Contributor Author

@helfgott helfgott Nov 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For latest/dry-run the version in ConfigReleaseVersions is: mule_module_maven_plugin="1.9.0-20241126" and that matches the pom.xml version: <version>1.9.0-20241126</version>.

I don't want to hardcode the value, is there any scenario when the versions might differ?

Or we just simply use a custom variable so our process update that property automatically?

Copy link
Contributor

@anosenzo anosenzo Dec 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, a new property like muleModuleMavenPluginVersion and you need to add a new dep entry in the mule-runtime-release config files, like it is done in mule repo https://github.com/mulesoft/mule/blob/master/pom.xml#L181 https://github.com/mulesoft/mule/blob/master/pom.xml#L494.

But as mentioned in htis comment #247 (comment) ideally avoid using a version here and try to use add the plugin to the the plugins parent https://github.com/mulesoft/mule-runtime-bom/blob/master/mule-plugin-mgmt-parent-pom/pom.xml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is exactly the property we should use: muleModuleMavenPluginVersion I recicled that, it is already declared in our internal config.

<executions>
<execution>
<id>analyze</id>
Expand Down