This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
fixes #33 discovery mode #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoiko
suggested changes
Apr 3, 2018
| ) | ||
| .demand(['f', 'p']) | ||
| .describe('f', 'Path to the RAML definition') | ||
| .describe('p', 'Port number to bind the proxy') | ||
| .describe('cors', 'Enable CORS with the API') | ||
| .describe('definition', 'URI of raml definition') |
There was a problem hiding this comment.
I think we shouldn't required an extra parameter here. Instead, we should build the URL based on the API baseUri of the RAML file provided by -f.
| @@ -48,6 +48,14 @@ function createServerFromBaseUri (raml, options) { | |||
| var app = osprey.Router() | |||
| var path = (raml.baseUri || '').replace(/^(\w+:)?\/\/[^/]+/, '') || '/' | |||
|
|
|||
| if (options.definition) { | |||
| app.use('/resources', function (req, res) { | |||
There was a problem hiding this comment.
why /resources? the way I read #33 is that it should work with all resources defined in the RAML definition.
| @@ -48,6 +48,14 @@ function createServerFromBaseUri (raml, options) { | |||
| var app = osprey.Router() | |||
| var path = (raml.baseUri || '').replace(/^(\w+:)?\/\/[^/]+/, '') || '/' | |||
|
|
|||
| if (options.definition) { | |||
| app.use('/resources', function (req, res) { | |||
| var body = '< link:"' + | |||
There was a problem hiding this comment.
I think the < is extraneous. It appears in the example of #33 because that's how curl formats headers returned in responses.
Also, to be clear, this should be returned as a header, not in the body.
| app.use('/resources', function (req, res) { | ||
| var body = '< link:"' + | ||
| options.definition + | ||
| '" rel="describedby" type="application/raml+yaml">' |
There was a problem hiding this comment.
The > here is wrong too. This should follow the header Link syntax as defined here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.