Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fine grained azure groups thats allowed #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

maartenschalekamp
Copy link

@maartenschalekamp maartenschalekamp commented Jun 3, 2022

Currently when setting the app.sso_azure_mode to groups it will sync all groups from Azure (Security and Distribution groups). This also not handled very good on the ui when viewing the users as it will overflow and getting all the groups synced was not very useful for us.

The suggested changes are the ability to select if you want only security groups or all groups, where currently all groups are forced. Usually security groups will be used for access control. Then also have a new list option to filter out which groups to be allowed to be synced.

These changes are really hard to test in a local dev environment as it requires a valid license.

So to completely make us of this feature you need to set the following.

app.sso_azure_mode = "groups"
app.sso_azure_security_groups_only = true
app.sso_azure_allow_groups = [ "AD_GROUP_NAME_ONE", "AD_GROUP_NAME_TWO" ]

So if the user logs in and they are assigned to security group AD_GROUP_NAME_ONE or AD_GROUP_NAME_TWO it will be added to their profile.

Copy link

@andy-g andy-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @maartenschalekamp 👍

This allows you to specify an array of azure groups as part of the settings right?

@maartenschalekamp
Copy link
Author

Looks good to me, thanks @maartenschalekamp 👍

This allows you to specify an array of azure groups as part of the settings right?

Thats correct, Ive added more details in the main comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants