This repository has been archived by the owner on Oct 17, 2019. It is now read-only.
Fix up includes to nlohmann json #448
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As written in the README of that project, see https://github.com/nlohmann/json/#integration
|
The build fails because the mtxclient PR isn't used in the build process. |
mujx
suggested changes
Sep 25, 2018
| @@ -73,7 +73,7 @@ set(JSON_HEADER_URL | |||
| set(JSON_HEADER_HASH | |||
| ce6b5610a051ec6795fa11c33854abebb086f0fd67c311f5921c3c07f9531b44) | |||
|
|
|||
| file(DOWNLOAD ${JSON_HEADER_URL} ${DEPS_INSTALL_DIR}/include/json.hpp | |||
| file(DOWNLOAD ${JSON_HEADER_URL} ${DEPS_INSTALL_DIR}/include/nlohmann/json.hpp | |||
There was a problem hiding this comment.
It would be better to use External_Project for this library and install it like the other dependencies. And then call find_package(nlohmann_json) which will fix the CI.
There was a problem hiding this comment.
Probably but it's more work 😉 I'll look into it soon-ish
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might require more changes for the changed include path
See also mujx/mtxclient#29