Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Add referenceDate on picker components (and DateRangeCalendar) #9991

Merged
merged 10 commits into from
Aug 29, 2023

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Aug 10, 2023

Fixes #6870
Fixes #5702

@flaviendelangle flaviendelangle self-assigned this Aug 10, 2023
@flaviendelangle flaviendelangle added the component: pickers This is the name of the generic UI component, not the React module! label Aug 10, 2023
@mui-bot
Copy link

mui-bot commented Aug 10, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-9991--material-ui-x.netlify.app/

Updated pages

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms -208.6 -65.4 -151.1 -129.36 48.06
Sort 100k rows ms 614.8 1,355.7 1,201 1,089.7 252.46
Select 100k rows ms 562.4 702.5 602.1 629.28 54.981
Deselect 100k rows ms 111.6 191 149.7 149.88 25.223

Generated by 🚫 dangerJS against 200ac53

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 11, 2023
@flaviendelangle flaviendelangle changed the title [pickers] Add referenceDate on picker components [pickers] Add referenceDate on picker components Aug 14, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 14, 2023
@flaviendelangle flaviendelangle changed the title [pickers] Add referenceDate on picker components [pickers] Add referenceDate on picker components (and DateRangeCalendar) Aug 14, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 16, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 16, 2023
@flaviendelangle
Copy link
Member Author

flaviendelangle commented Aug 21, 2023

Conclusion in our weekly meeting

We create one new section in Base concepts (named Reference date when there is no value defined or something similar).
In this section, we talk about the default behavior (we use the validation props). And we add an example of how people can override it using referenceDate.

Based on the issues that made us create this prop, we create sections on component pages (DigitalClock and DateCalendar probably) where we show how to solve those product issues (for example on the DateCalendar it would be something like Choose the initial month and year).

@flaviendelangle flaviendelangle marked this pull request as ready for review August 24, 2023 13:01
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work finalizing the referenceDate feature! 💙

Is my memory deceiving me, but didn't we have issues, where people wanted to have a certain reference date used and allow selecting only day and month?
If that is indeed true, do you think it's worth having a demo about it? 🤔

@flaviendelangle
Copy link
Member Author

Didn't we have issues, where people wanted to have a certain reference date used and allow selecting only day and month?

I don't recall it, but if we can find the issue sure!

@flaviendelangle flaviendelangle merged commit 3329a60 into mui:master Aug 29, 2023
@flaviendelangle flaviendelangle deleted the referenceDate-pickers branch August 29, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pickers] Add ability to set a default time for DateTime pickers
3 participants