-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Add referenceDate
on picker components (and DateRangeCalendar
)
#9991
[pickers] Add referenceDate
on picker components (and DateRangeCalendar
)
#9991
Conversation
Netlify deploy previewNetlify deploy preview: https://deploy-preview-9991--material-ui-x.netlify.app/ Updated pages
These are the results for the performance tests:
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
referenceDate
on picker components
15d0714
to
8eba2e4
Compare
8eba2e4
to
257d094
Compare
referenceDate
on picker componentsreferenceDate
on picker components (and DateRangeCalendar
)
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conclusion in our weekly meeting We create one new section in Base concepts (named Reference date when there is no value defined or something similar). Based on the issues that made us create this prop, we create sections on component pages (DigitalClock and DateCalendar probably) where we show how to solve those product issues (for example on the DateCalendar it would be something like Choose the initial month and year). |
5de4deb
to
2ae9f99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work finalizing the referenceDate
feature! 💙
Is my memory deceiving me, but didn't we have issues, where people wanted to have a certain reference
date used and allow selecting only day and month?
If that is indeed true, do you think it's worth having a demo about it? 🤔
docs/data/date-pickers/base-concepts/ReferenceDateDefaultBehavior.tsx
Outdated
Show resolved
Hide resolved
docs/data/date-pickers/base-concepts/ReferenceDateDefaultBehavior.tsx
Outdated
Show resolved
Hide resolved
docs/data/date-pickers/base-concepts/ReferenceDateExplicitDateTimePicker.tsx
Outdated
Show resolved
Hide resolved
I don't recall it, but if we can find the issue sure! |
Fixes #6870
Fixes #5702