Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Fix date calendar issues #9652

Merged
merged 4 commits into from
Jul 12, 2023
Merged

[pickers] Fix date calendar issues #9652

merged 4 commits into from
Jul 12, 2023

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Jul 12, 2023 •
edited
Loading

Extract fixes done in #8851.

  • Remove redundant "pen icon" styles as this feature has been removed in v6.
  • Fix date range calendar selected day styling when a selected day is being dragged
  • Remove unwanted opacity on selected day range days

@LukasTy LukasTy added bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! design: ui labels Jul 12, 2023
@LukasTy LukasTy self-assigned this Jul 12, 2023
@mui-bot
Copy link

mui-bot commented Jul 12, 2023 •
edited
Loading

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-9652--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 317.2 508 504.4 430.82 92.696
Sort 100k rows ms 426.8 841.3 800.4 722.64 153.389
Select 100k rows ms 143.4 258.1 180 185.74 38.787
Deselect 100k rows ms 125 203.6 176.2 168.16 31.839

Generated by 🚫 dangerJS against 52aacee

@LukasTy LukasTy enabled auto-merge (squash) July 12, 2023 13:33
@LukasTy LukasTy merged commit be71749 into mui:master Jul 12, 2023
@LukasTy LukasTy deleted the fix-date-calendar-bugs branch July 12, 2023 13:38
@oliviertassinari oliviertassinari added design This is about UI or UX design, please involve a designer and removed design: ui labels Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

@noraleonte noraleonte Awaiting requested review from noraleonte

Assignees

@LukasTy LukasTy

Labels
bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LukasTy @mui-bot @alexfauquette @oliviertassinari