Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Rename Checkbox component and props slots to BaseCheckbox #3142

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

DanailH
Copy link
Member

@DanailH DanailH commented Nov 9, 2021

Part of #3066 and #2944

Based on this comment #3066 (comment)

Breaking change

As a start of the effort for #3066, we first need to update the names of the base components that we already have created as part of the DataGrid and DataGridPro API. Since this is a breaking change it needs to be done before the v5 stable release.

components prop change:

 <DataGrid
   components={{
-    checkbox: MyCustomCheckbox,
+    BaseCheckbox: MyCustomCheckbox,
   }}
 />;

componentsProp prop change:

 <DataGrid
   componentsProps={{
-    checkbox: {},
+    baseCheckbox: {},
   }}
 />;

Note: these changes apply to both the DataGrid and DataGridPro components.

@DanailH DanailH added breaking change component: data grid This is the name of the generic UI component, not the React module! components: DataGridPro labels Nov 9, 2021
@DanailH DanailH added this to the v5 stable version milestone Nov 9, 2021
@DanailH DanailH self-assigned this Nov 9, 2021
Copy link
Member

@m4theushw m4theushw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Before merging into next, merge with next first and delete docs/tsconfig.tsbuildinfo. It's a cache file.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 9, 2021
@github-actions
Copy link

github-actions bot commented Nov 9, 2021

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 9, 2021
@DanailH DanailH merged commit 005df0e into mui:next Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants