[core] Drop context folder #2501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
requested review from
m4theushw,
oliviertassinari and
DanailH
|
I guess we have moved the discussion to #2522. |
|
Could we close this one or do you want to push it forward? |
|
@m4theushw I'll close it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mui-org/x the
OutsideColumnsPanelstory is not working innextbecause it tries to use the preference panel outside of the Grid, but the panel usesuseGridRootPropswhich is not available.To be able to access
apiRef, it instanciatesGridApiContext.Providermanually, which I would like to avoid.But anyway, for
rootPropsI don't see how we could correctly handle it.It we just export the context, users would not have the (
DataGridProps|DataGridProProps) =>GridComponentPropsprocessing so therootPropswould not be complete.Do we really want to allow people to instanciate our components outside of the Grid context.
It seems to be a lot of trouble and very easy to break in the future.