[pickers] Replace the onOpen() and onClose() methods of usePickerContext() with a single setOpen() method
#15701
+128
−167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
the
component: pickers
flaviendelangle
changed the title
onToggleOpening to the picker public contextonToggleOpening to usePickerContext()
|
Deploy preview: https://deploy-preview-15701--material-ui-x.netlify.app/ Updated pages: |
5 tasks
LukasTy
reviewed
Dec 3, 2024
packages/x-date-pickers/src/internals/components/PickerProvider.tsx
Outdated
Show resolved
Hide resolved
Yes, we were debating between an |
flaviendelangle
changed the title
onToggleOpening to usePickerContext()onOpen() and onClose() methods of usePickerContext() with a single setOpen() method.
flaviendelangle
force-pushed
the
ctx-onToggleOpening
branch
from
4680590
to
080521d
Compare
flaviendelangle
force-pushed
the
ctx-onToggleOpening
branch
from
080521d
to
c0e4ced
Compare
flaviendelangle
commented
Dec 4, 2024
| @@ -8,7 +8,7 @@ export interface OpenStateProps { | |||
|
|
|||
| export const useOpenState = ({ open, onOpen, onClose }: OpenStateProps) => { | |||
There was a problem hiding this comment.
No behavior change, I just aligned the wording a bit
LukasTy
added
breaking change
enhancement
LukasTy
approved these changes
Dec 4, 2024
docs/data/migration/migration-pickers-v7/migration-pickers-v7.md
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/internals/hooks/usePicker/usePickerValue.types.ts
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/internals/hooks/usePicker/usePickerValue.types.ts
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/internals/hooks/usePicker/usePickerValue.types.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Lukas Tyla <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>
…rValue.types.ts Co-authored-by: Lukas Tyla <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>
…rValue.types.ts Co-authored-by: Lukas Tyla <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>
…rValue.types.ts Co-authored-by: Lukas Tyla <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>
oliviertassinari
changed the title
onOpen() and onClose() methods of usePickerContext() with a single setOpen() method.onOpen() and onClose() methods of usePickerContext() with a single setOpen() method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #15671, I started to duplicate a lot the
handleTogglePickermethod.