Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MUI Core to ^5.16.8 #15644

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Bump MUI Core to ^5.16.8 #15644

merged 4 commits into from
Nov 29, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 28, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@mui/icons-material (source) ^5.16.7 -> ^5.16.8 age adoption passing confidence
@mui/material (source) ^5.16.7 -> ^5.16.8 age adoption passing confidence
@mui/material-nextjs (source) ^5.16.6 -> ^5.16.8 age adoption passing confidence
@mui/styles (source) ^5.16.7 -> ^5.16.8 age adoption passing confidence
@mui/system (source) ^5.16.7 -> ^5.16.8 age adoption passing confidence
@mui/utils (source) ^5.16.6 -> ^5.16.8 age adoption passing confidence

Release Notes

mui/material-ui (@​mui/icons-material)

v5.16.8

Compare Source

A big thanks to the 8 contributors who made this release possible.

@mui/[email protected]
@mui/[email protected]
Docs
Core

All contributors of this release in alphabetical order: @​alexfauquette, @​cherniavskii, @​DiegoAndai, @​jukkatupamaki, @​michelengelen, @​oliviertassinari, @​rluzists1, @​siriwatknp


Configuration

📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Update of dependencies label Nov 28, 2024
@mui-bot
Copy link

mui-bot commented Nov 28, 2024

Deploy preview: https://deploy-preview-15644--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against f0f1276

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 28, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 28, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 28, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 28, 2024
Copy link
Contributor Author

renovate bot commented Nov 28, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@JCQuintas
Copy link
Member

@LukasTy updating monorepo hash fixes the netlify deploy, but eslint complains about translations on the docs. Should we add those keys?

/mui-x/docs/src/modules/components/CustomizationPlayground.tsx
  147:20  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels
  243:24  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels
  253:20  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels
  357:43  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels
  374:47  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels
  391:43  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels

/mui-x/docs/src/modules/components/DemoPropsForm.tsx
  196:10  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels
  200:22  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels
  430:28  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels

/mui-x/docs/src/modules/components/PickersPlayground.tsx
  107:38  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels
  108:33  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels
  109:41  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels
  273:54  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels
  547:62  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels
  660:12  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels

/mui-x/docs/src/modules/components/overview/CommunityOrPro.tsx
  23:79  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels
  32:14  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels
  35:64  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels
  46:12  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels

/mui-x/docs/src/modules/components/overview/DateLibraries.tsx
  61:60  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels
  79:26  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels
  94:14  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels

/mui-x/docs/src/modules/components/overview/FeatureHighlight.tsx
  37:96  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels
  46:12  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels
  49:81  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels

/mui-x/docs/src/modules/components/overview/Internationalization.tsx
   92:73  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels
  187:20  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels
  192:43  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels
  195:43  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels

/mui-x/docs/src/modules/components/overview/Keyboard.tsx
  460:60  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels
  471:12  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels

/mui-x/docs/src/modules/components/overview/XLogo.tsx
  25:83  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels

/mui-x/docs/src/modules/components/overview/mainDemo/Birthday.tsx
  28:60  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels

/mui-x/docs/src/modules/components/overview/mainDemo/DigitalClock.tsx
  44:61  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels

/mui-x/docs/src/modules/components/overview/mainDemo/FlightPicker.tsx
  12:54  error  Don't use hardcoded labels. Prefer translated values by using `useTranslate`. New translations should be added to `docs/translations/translations.json`  material-ui/no-hardcoded-labels

@LukasTy
Copy link
Member

LukasTy commented Nov 29, 2024

updating monorepo hash fixes the netlify deploy, but eslint complains about translations on the docs. Should we add those keys?

@JCQuintas I'm not sure we should, especially given changes in mui/material-ui#44489 where such cases are ignored 🤔
@oliviertassinari could you confirm if this wasn't a mistake?
AFAIK, our docs are no longer translated, why do we enforce the usage of useTranslate? 🤷

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 29, 2024

The rule was only applied to .js file extensions before, I made it **. Since we don't translate docs, not anymore (but I don't think this is right), we can add eslint disable line

@LukasTy LukasTy enabled auto-merge (squash) November 29, 2024 11:46
@LukasTy LukasTy merged commit fa4a01b into master Nov 29, 2024
16 checks passed
@LukasTy LukasTy deleted the renovate/mui-core branch November 29, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update of dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants