Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Replace use of e.g. with for example #15572

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

oliviertassinari
Copy link
Member

Allow to smoothly upgrade docs-infra for when mui/material-ui#44513 lands.

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Nov 23, 2024
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Nov 23, 2024
@samuelsycamore
Copy link
Contributor

I think in all cases here it'd be preferable to replace the colon with a comma.

- for example:
+ for example,

Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of : seemed weird to me

EDIT: I didn't see @samuelsycamore comment sorry.
I'm fine with always adding for example,

packages/x-date-pickers/src/models/adapters.ts Outdated Show resolved Hide resolved
packages/x-date-pickers/src/models/adapters.ts Outdated Show resolved Hide resolved
packages/x-date-pickers/src/models/adapters.ts Outdated Show resolved Hide resolved
@oliviertassinari oliviertassinari merged commit ce9f0cc into mui:master Nov 27, 2024
18 checks passed
@oliviertassinari oliviertassinari deleted the fix-eg branch November 27, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants