Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove dead translation key #15566

Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Nov 23, 2024

The key doesn't seem to be used. It was added #15401. I guess we can remove it?

I also wonder:

@oliviertassinari oliviertassinari added core Infrastructure work going on behind the scenes component: data grid This is the name of the generic UI component, not the React module! labels Nov 23, 2024
@mui-bot
Copy link

mui-bot commented Nov 23, 2024

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running pnpm l10n
  • Clean files with pnpm prettier.

Deploy preview: https://deploy-preview-15566--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against be4680d

Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with both the points.

  1. Having common ones would reduce the need to translate repeating ones like Search, Clear, Reset, etc.
  2. Having the translation keys skipped for an unstable feature would control some noise, however we'd need to be a bit more careful to have the translation keys in place when making such a feature stable.

@flaviendelangle
Copy link
Member

if we should add translation keys for unstable features. People then tends to create PRs to translate those, but it can be noise until it's stable.

We were discussing last week how to make those new features (that we currenctly mark as experimental or unstable) more appealing in order to have feedbacks.
I fear that not translating those features before they are stable would cause yet another reason not to use those features, making it harder to stabilize them.

@arminmeh
Copy link
Contributor

arminmeh commented Nov 25, 2024

if we should we use a // Common structure like used in:

in most of the cases this should be fine, but we should be careful with it because you lose context and it can make the word (or its spelling) different in other languages.

example: word Add is in Croatian translated to Zbroji if it is a math operation and Dodaj if it is an action to append an item to the list

@oliviertassinari oliviertassinari force-pushed the remove-dead-translation-key branch from efb1e7e to be4680d Compare November 25, 2024 14:58
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Nov 25, 2024

We were discussing last week how to make those new features (that we currenctly mark as experimental or unstable) more appealing in order to have feedbacks.
I fear that not translating those features before they are stable would cause yet another reason not to use those features, making it harder to stabilize them.

@flaviendelangle en-US is 50% of the internet content: https://en.wikipedia.org/wiki/Languages_used_on_the_Internet. Might be similar to our customers/developer users as well. However, if we look at the Internet users by language:

SCR-20241125-ofay

It seems that 10 locales could give us 70% of coverage. (It's almost the Pareto principle here). So for unstable features, maybe we don't need 100 locales, only the top 10? This could be a way:

Not super important in any cases.

@oliviertassinari oliviertassinari merged commit d6bc10a into mui:master Nov 25, 2024
15 of 16 checks passed
@oliviertassinari oliviertassinari deleted the remove-dead-translation-key branch November 25, 2024 15:14
LukasTy pushed a commit to LukasTy/mui-x that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes l10n localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants