-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Remove dead translation key #15566
[core] Remove dead translation key #15566
Conversation
Localization writing tips ✍️Seems you are updating localization 🌍 files. Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️
Deploy preview: https://deploy-preview-15566--material-ui-x.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with both the points.
- Having common ones would reduce the need to translate repeating ones like
Search
,Clear
,Reset
, etc. - Having the translation keys skipped for an unstable feature would control some noise, however we'd need to be a bit more careful to have the translation keys in place when making such a feature stable.
We were discussing last week how to make those new features (that we currenctly mark as |
in most of the cases this should be fine, but we should be careful with it because you lose context and it can make the word (or its spelling) different in other languages. example: word |
efb1e7e
to
be4680d
Compare
@flaviendelangle en-US is 50% of the internet content: https://en.wikipedia.org/wiki/Languages_used_on_the_Internet. Might be similar to our customers/developer users as well. However, if we look at the Internet users by language: It seems that 10 locales could give us 70% of coverage. (It's almost the Pareto principle here). So for unstable features, maybe we don't need 100 locales, only the top 10? This could be a way:
Not super important in any cases. |
The key doesn't seem to be used. It was added #15401. I guess we can remove it?
I also wonder:
if we should we use a // Common structure for the data grid like used for the pickers:
mui-x/packages/x-date-pickers/src/locales/enUS.ts
Lines 87 to 88 in 483fc6a
We start to have quite some duplication for clear: x3. https://github.com/search?q=repo%3Amui%2Fmui-x+Clear+path%3A%2F%5Epackages%5C%2Fx-data-grid%5C%2Fsrc%5C%2Fconstants%5C%2F%2F&type=code.
if we should add translation keys for unstable features. People then tends to create PRs to translate those, but it can be noise until it's stable.