[DataGrid] Fix scroll error #15521
[DataGrid] Fix scroll error #15521
Conversation
cherniavskii
added
bug 🐛
|
Deploy preview: https://deploy-preview-15521--material-ui-x.netlify.app/ |
| @@ -216,9 +216,14 @@ export const useGridVirtualScroller = () => { | |||
| ); | |||
|
|
|||
| const triggerUpdateRenderContext = useEventCallback(() => { | |||
| const scroller = scrollerRef.current; | |||
| if (!scroller) { | |||
There was a problem hiding this comment.
I still can't help myself asking if this is not hiding something.
It could be about useTimeout that uses useOnMount, that uses useEffect so call the clear function async, so after the DOM node was unmounted, ref was set to null. Changing useTimeout to use useLayoutEffect to run clean-up in sync mode could solve this.
There was a problem hiding this comment.
after the DOM node was unmounted, ref was set to null
I tried reproducing it #14987 (comment), but I couldn't get any scrolling callbacks called after the grid was unmounted.
| top: scrollerRef.current!.scrollTop, | ||
| left: scrollerRef.current!.scrollLeft, | ||
| top: scroller.scrollTop, | ||
| left: scroller.scrollLeft, |
There was a problem hiding this comment.
The ! type annotation causing yet another bug.
|
Cherry-pick PRs will be created targeting branches: v7.x |
Fixes #14987 (comment)
I can't reproduce the issue, but early return makes sense here anyway.