Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Tentative fix for Argos flaky screenshot tests - Take 2 #15398

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

JCQuintas
Copy link
Member

@JCQuintas JCQuintas commented Nov 13, 2024

Related to this error that is still happening: https://app.argos-ci.com/mui/mui-x/builds/26434/118865224

@JCQuintas JCQuintas added needs cherry-pick The PR should be cherry-picked to master after merge v7.x scope: code-infra Specific to the core-infra product labels Nov 13, 2024
@JCQuintas JCQuintas requested a review from LukasTy November 13, 2024 12:13
@JCQuintas JCQuintas self-assigned this Nov 13, 2024
@JCQuintas
Copy link
Member Author

@LukasTy will use the result of this cherrypick to add the changes from the previous related PR

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hope that this is the problematic place. 🤞

@mui-bot
Copy link

mui-bot commented Nov 13, 2024

Deploy preview: https://deploy-preview-15398--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against d290285

@JCQuintas
Copy link
Member Author

At least it fixed the error on the first try, lets see 🤞

@JCQuintas JCQuintas enabled auto-merge (squash) November 13, 2024 12:27
@JCQuintas JCQuintas merged commit e6ce887 into mui:master Nov 13, 2024
16 checks passed
@JCQuintas JCQuintas deleted the argos-flaky-ss-take-2 branch November 13, 2024 12:30
Copy link

Cherry-pick PRs will be created targeting branches: v7.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs cherry-pick The PR should be cherry-picked to master after merge scope: code-infra Specific to the core-infra product v7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants