[code-infra] Tentative fix for Argos flaky screenshot tests #15374
Conversation
JCQuintas
added
enhancement
| @@ -62,7 +62,7 @@ async function main() { | |||
|
|
|||
| // Wait for all requests to finish. | |||
| // This should load shared resources such as fonts. | |||
| await page.goto(`${baseUrl}#no-dev`, { waitUntil: 'networkidle0' }); | |||
| await page.goto(`${baseUrl}#no-dev`, { waitUntil: 'networkidle' }); | |||
There was a problem hiding this comment.
Are you sure? 🤔
https://www.webshare.io/academy-article/puppeteer-networkidle0-vs-networkidle2
it seems like it is correct. 🤔
There was a problem hiding this comment.
We are using playwright, the types flag that as a type error
There was a problem hiding this comment.
Ok, nice. 👍
It's a difference between Playwright and Puppeteer. 🙈
https://playwright.dev/docs/api/class-page#page-goto-option-wait-until
|
Deploy preview: https://deploy-preview-15374--material-ui-x.netlify.app/ |
| @@ -62,7 +62,7 @@ async function main() { | |||
|
|
|||
| // Wait for all requests to finish. | |||
| // This should load shared resources such as fonts. | |||
| await page.goto(`${baseUrl}#no-dev`, { waitUntil: 'networkidle0' }); | |||
| await page.goto(`${baseUrl}#no-dev`, { waitUntil: 'networkidle' }); | |||
There was a problem hiding this comment.
Are you sure? 🤔
https://www.webshare.io/academy-article/puppeteer-networkidle0-vs-networkidle2
it seems like it is correct. 🤔
| @@ -62,7 +62,7 @@ async function main() { | |||
|
|
|||
| // Wait for all requests to finish. | |||
| // This should load shared resources such as fonts. | |||
| await page.goto(`${baseUrl}#no-dev`, { waitUntil: 'networkidle0' }); | |||
| await page.goto(`${baseUrl}#no-dev`, { waitUntil: 'networkidle' }); | |||
There was a problem hiding this comment.
Ok, nice. 👍
It's a difference between Playwright and Puppeteer. 🙈
https://playwright.dev/docs/api/class-page#page-goto-option-wait-until
|
WDYT, @JCQuintas, should we cherry-pick this to v7.x as we'll be doing a lot of PRs for that branch? 🤔 |
|
probably, yeah |
(cherry picked from commit 60d0913)
page.waitForLoadState()before screenshot