-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Introduce a new concept of manager
#15339
Open
flaviendelangle
wants to merge
81
commits into
mui:master
Choose a base branch
from
flaviendelangle:v8-value-manager
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+905
−263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview: https://deploy-preview-15339--material-ui-x.netlify.app/ |
flaviendelangle
force-pushed
the
v8-value-manager
branch
from
November 8, 2024 12:12
88503cb
to
bbd4fe2
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Nov 12, 2024
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Nov 12, 2024
flaviendelangle
force-pushed
the
v8-value-manager
branch
2 times, most recently
from
November 13, 2024 08:18
01934b9
to
1390421
Compare
flaviendelangle
force-pushed
the
v8-value-manager
branch
from
November 13, 2024 08:19
1390421
to
eda4787
Compare
flaviendelangle
force-pushed
the
v8-value-manager
branch
2 times, most recently
from
November 13, 2024 09:34
f1e96db
to
8592c72
Compare
flaviendelangle
force-pushed
the
v8-value-manager
branch
from
November 13, 2024 09:46
8592c72
to
f06c8ca
Compare
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Nov 25, 2024
flaviendelangle
added
the
component: pickers
This is the name of the generic UI component, not the React module!
label
Nov 25, 2024
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Nov 26, 2024
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Nov 26, 2024
flaviendelangle
force-pushed
the
v8-value-manager
branch
from
November 26, 2024 10:22
6c0d13c
to
43b1180
Compare
Co-authored-by: Lukas Tyla <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Nov 28, 2024
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #15395
You can look at #15505 to see the benefit of this approach in a concrete use case.
In this PR
Todo after this PR
useField
to only have two parameters (manager
andprops
)useField
instead of insideuseDateField
& couseDateField
& co inDateField
& co and instead directly use the manager