Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Introduce a new concept of manager #15339

Open
wants to merge 80 commits into
base: master
Choose a base branch
from

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Nov 8, 2024

Part of #15395

You can look at #15505 to see the benefit of this approach in a concrete use case.

In this PR

  • Create the interfaces for the new manager
  • Create the hooks to create all the managers (date, time, date time, date range, time range and date time range)

Todo after this PR

  • Stop duplicating logic in the multi input range field ([pickers] POC: Use the new managers for the multi input range fields #15505)
  • Rework useField to only have two parameters (manager and props)
  • Move the application of the default props inside useField instead of inside useDateField & co
  • Extend the new manager to work with the picker (the exact needs are unclear for now, we should be able to move the application of default props inside it like for the field)
  • Stop using useDateField & co in DateField & co and instead directly use the manager

@flaviendelangle flaviendelangle self-assigned this Nov 8, 2024
@mui-bot
Copy link

mui-bot commented Nov 8, 2024

Deploy preview: https://deploy-preview-15339--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against ca36470

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 12, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 12, 2024
@flaviendelangle flaviendelangle force-pushed the v8-value-manager branch 2 times, most recently from 01934b9 to 1390421 Compare November 13, 2024 08:18
@flaviendelangle flaviendelangle force-pushed the v8-value-manager branch 2 times, most recently from f1e96db to 8592c72 Compare November 13, 2024 09:34
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 25, 2024
@flaviendelangle flaviendelangle added the component: pickers This is the name of the generic UI component, not the React module! label Nov 25, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 26, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 26, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 28, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 28, 2024
@flaviendelangle flaviendelangle marked this pull request as ready for review November 28, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants