Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] Fix log scale with null data #15337

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Nov 8, 2024

Fix #15322

A null leads to a stack [0, 0] which make the domain includes 0.

Thsi PR add a check to ignore en element when it comes from a null data point

@alexfauquette alexfauquette added bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module! labels Nov 8, 2024
@JCQuintas JCQuintas added needs cherry-pick The PR should be cherry-picked to master after merge v7.x labels Nov 8, 2024
@mui-bot
Copy link

mui-bot commented Nov 8, 2024

Deploy preview: https://deploy-preview-15337--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 2cdf112

Copy link

codspeed-hq bot commented Nov 8, 2024

CodSpeed Performance Report

Merging #15337 will not alter performance

Comparing alexfauquette:fix-line-extremums (2cdf112) with master (10cf25d)

Summary

✅ 3 untouched benchmarks

@JCQuintas
Copy link
Member

Would the argos change be breaking? 🤔

@alexfauquette
Copy link
Member Author

Would the argos change be breaking? 🤔

Since there is a workaround for v7 we can release it only in v8

@alexfauquette alexfauquette removed needs cherry-pick The PR should be cherry-picked to master after merge v7.x labels Nov 8, 2024
@JCQuintas JCQuintas merged commit 7c4c924 into mui:master Nov 8, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module!
Projects
None yet
3 participants