[docs] Fix hard coded URL domain #15329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
commented
Nov 7, 2024
| - The `columnVisibilityChange` event was removed. Use [`columnVisibilityModelChange`](https://mui.com/x/react-data-grid/events/#catalog-of-events) instead. | ||
| - The `columnVisibilityChange` event was removed. Use [`columnVisibilityModelChange`](https://v6.mui.com/x/react-data-grid/events/#catalog-of-events) instead. |
There was a problem hiding this comment.
Migration guide, we likely don't want to have to care about keeping those links working, they might not even stay relevant with different majors.
|
Deploy preview: https://deploy-preview-15329--material-ui-x.netlify.app/ Updated pages: |
oliviertassinari
commented
Nov 7, 2024
| If the filter operator has a [custom `InputComponent`](https://mui.com/x/react-data-grid/filtering/#custom-input-component), the same component is being used for the header filter. | ||
| If the filter operator has a [custom `InputComponent`](/x/react-data-grid/filtering/customization/#custom-input-component), the same component is being used for the header filter. |
There was a problem hiding this comment.
That link was broken.
There was a problem hiding this comment.
Wasn't caught by the link-check because of the full URL I guess?
MBilalShafi
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A side quick win I noticed while wanting to help with #15251.
The objective of this change is to:
It's relevant for docs versioning too. We use subdomains today, so it would point to the wrong domain. If we moved to do docs versioning with subfolders, it would also have the wrong URL prefix.
@vladmoroz We likely don't want to start thinking now on how we will version Base UI, etc. docs. I have seen it's common to use subfolders (Material UI used subdomains so far), maybe they do this for SEO to reinforce backlinks on a single domain, or maybe to make it impossible to have duplication of other pages, e.g. marketing homepage.
Anyway, creating this page as we have time: https://www.notion.so/mui-org/docs-infra-How-to-version-docs-138cbfe7b66080f78d3bd679deec8fa9.