Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add PickersPopper component to customization playground #15305

Merged
merged 2 commits into from
Nov 13, 2024
Merged

[docs] Add PickersPopper component to customization playground #15305

merged 2 commits into from
Nov 13, 2024

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Nov 6, 2024

Fixes #15263.

@LukasTy LukasTy added docs Improvements or additions to the documentation component: pickers This is the name of the generic UI component, not the React module! labels Nov 6, 2024
@LukasTy LukasTy self-assigned this Nov 6, 2024
@LukasTy LukasTy mentioned this pull request Nov 6, 2024
Closed
LukasTy
LukasTy commented Nov 6, 2024
View reviewed changes
docs/data/date-pickers/date-picker/examplesConfig.styling.tsx
styledComponents: {
type: 'warning',
parentSlot: 'desktopPaper',
parentComponent: 'Paper',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PickersPopper is an internal component, I think that it is better to show the compromise of overriding it with MuiPaper instead. 🤔

@LukasTy LukasTy added the needs cherry-pick The PR should be cherry-picked to master after merge label Nov 6, 2024
@mui-bot
Copy link

mui-bot commented Nov 6, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-15305--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 73977e4

@LukasTy LukasTy added the v7.x label Nov 6, 2024
@flaviendelangle
Copy link
Member

image

I did not check the changes in depth, but as is it's a weird experience to play with the PickersPopper on the customization playground 😬

@LukasTy
Copy link
Member Author

LukasTy commented Nov 6, 2024

Are you suggesting removing the root slot to reduce the cases of "unclear" result states? 🤔

@flaviendelangle
Copy link
Member

Do you see some customization use cases for the root?
Maybe we could at least change the dedault selected slot on the UI

@LukasTy
Copy link
Member Author

LukasTy commented Nov 7, 2024

Do you see some customization use cases for the root?
Maybe we could at least change the dedault selected slot on the UI

I have changed the order of the slots and the first one (paper) is now the default.

@LukasTy LukasTy merged commit fba7614 into mui:master Nov 13, 2024
18 checks passed
@LukasTy LukasTy deleted the add-pickers-popper-customization-example branch November 13, 2024 11:31
@github-actions GitHub Actions
Copy link

Cherry-pick PRs will be created targeting branches: v7.x

github-actions bot pushed a commit that referenced this pull request Nov 13, 2024
@LukasTy @web-flow
[docs] Add PickersPopper component to customization playground (#15305
fea0733 
)
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

@arthurbalduini arthurbalduini Awaiting requested review from arthurbalduini

@noraleonte noraleonte Awaiting requested review from noraleonte

Assignees

@LukasTy LukasTy

Labels
component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation needs cherry-pick The PR should be cherry-picked to master after merge v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] Date Picker customization borderRadius does not round all components
3 participants
@LukasTy @mui-bot @flaviendelangle