Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Unify JSDoc for all the disabled and readOnly props #15304

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Nov 6, 2024

Needed for #15300

Right now it's a mess 😆
Sometimes there is a description, sometimes there is none, sometimes there is a discussion talking about "picker" when we are on DateCalendar etc...

I wrote a description that is component-agnostic and can be applied to any component, that way we don't have to worry that DatePicker extends DateCalendar and ends up with a description that makes no sense.
The descriptions can be found in this file

@flaviendelangle flaviendelangle self-assigned this Nov 6, 2024
@flaviendelangle flaviendelangle added breaking change component: pickers This is the name of the generic UI component, not the React module! and removed breaking change labels Nov 6, 2024
@mui-bot
Copy link

mui-bot commented Nov 6, 2024

Deploy preview: https://deploy-preview-15304--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against a38d5aa

@flaviendelangle flaviendelangle changed the title [pickers] Unify JSDoc for all the disabled and readOnly props [pickers] Unify JSDoc for all the disabled and readOnly props Nov 6, 2024
@flaviendelangle flaviendelangle marked this pull request as ready for review November 6, 2024 15:30
Copy link
Contributor

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor grammatical nitpick, otherwise I'm happy with the boilerplate text. 👍

@flaviendelangle flaviendelangle merged commit 5ee9eab into mui:master Nov 12, 2024
18 checks passed
@flaviendelangle flaviendelangle deleted the disabled-readOnly-typing branch November 12, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants