-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] MultiSectionDigitalClock layout review #15258
base: master
Are you sure you want to change the base?
[pickers] MultiSectionDigitalClock layout review #15258
Conversation
@@ -118,7 +126,7 @@ const PickersLayout = React.forwardRef(function PickersLayout< | |||
> | |||
{isLandscape ? shortcuts : toolbar} | |||
{isLandscape ? toolbar : shortcuts} | |||
<PickersLayoutContentWrapper className={classes.contentWrapper}> | |||
<PickersLayoutContentWrapper ownerState={{ valueType }} className={classes.contentWrapper}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in the main PR, the ownerState should comme from usePickerLayout
.
But overall I have an issue with this BC because PickersLayoutContentWrapper
is public so people will need to pass manually the ownerState
and it's not a great DX IMHO.
We really need to rework the whole DX at some point to hide those implementation details.
Deploy preview: https://deploy-preview-15258--material-ui-x.netlify.app/ |
I think the design changes make sense in this case 👌 |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Once #15494 is merged, you should be able to just add |
Extracted from #14397
When working on the PR mentioned above, it was noticed that currently the actionBar causes a stretch on the MultiSectionDigitalClock, causing UI issues:
Currently, we have a slight misalignment of the margins when two or more actions are available
I proposed some changes on the UI on that PR, but it led to discussions so it made sense to discuss it separately, where we can all discuss design changes. The image below illustrates the impacts of the change.
Some inputs to the discussions: