-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump React #15255
Bump React #15255
Changes from 24 commits
79a0cbf
2c71612
a689d8a
46a0052
9ee51e7
1c7a7d4
13acded
72d2eb7
b162a8b
e19eb7d
2f94d98
842561c
174433d
868a335
5daff1e
8b4fb9d
4865bf1
b3dabe1
b26a822
65e9d1f
602cb3a
ad494f8
43f59a3
50ae593
88e7702
f93c892
0b1e3cc
00b586f
5a1cd23
6a86fe4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,10 @@ | ||
<DataGrid | ||
{...data} | ||
slots={{ | ||
toolbar: CustomToolbar as GridSlots['toolbar'], | ||
}} | ||
slots={{ toolbar: CustomToolbar }} | ||
slotProps={{ | ||
panel: { | ||
anchorEl: filterButtonEl, | ||
}, | ||
toolbar: { | ||
setFilterButtonEl, | ||
}, | ||
toolbar: { setFilterButtonEl }, | ||
}} | ||
/> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -64,7 +64,7 @@ export interface GridRowProps extends React.HTMLAttributes<HTMLDivElement> { | |
onDoubleClick?: React.MouseEventHandler<HTMLDivElement>; | ||
onMouseEnter?: React.MouseEventHandler<HTMLDivElement>; | ||
onMouseLeave?: React.MouseEventHandler<HTMLDivElement>; | ||
[x: string]: any; // Allow custom attributes like data-* and aria-* | ||
[x: `data-${string}`]: string; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @mui/xgrid Are you sure we need to do this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For context—no other package is providing this explicit type, if anyone needs to provide it, they are probably fighting TS as well. |
||
} | ||
|
||
function EmptyCell({ width }: { width: number }) { | ||
|
@@ -109,7 +109,6 @@ const GridRow = React.forwardRef<HTMLDivElement, GridRowProps>(function GridRow( | |
isLastVisible, | ||
isNotVisible, | ||
showBottomBorder, | ||
focusedCell, | ||
tabbableCell, | ||
onClick, | ||
onDoubleClick, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
pro
andpremium
package module augmentation are mixed in a single project—it goes haywire. 🙈There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some of this dogfooding—this is my main gripe with module augmentation. 🙈
If users extend the same types for different package versions—they come to experience unexpected behavior. 🤷