[DataGrid] Improve row selection propagation trigger #15184
Conversation
MBilalShafi
added
bug 🐛
|
Deploy preview: https://deploy-preview-15184--material-ui-x.netlify.app/ |
| const filteredRowsLookup = gridFilteredRowsLookupSelector(apiRef); | ||
|
|
||
| // We clone the existing object to avoid mutating the same object returned by the selector to others part of the project | ||
| const selectionLookup = { ...selectedIdsLookupSelector(apiRef) }; | ||
|
|
||
| const isNonExistent = (id: GridRowId) => { | ||
| if (props.filterMode === 'server') { | ||
| return !rowsLookup[id]; |
There was a problem hiding this comment.
There is no filteredRowsLookup when filterMode='server'
|
Is there any idea when this PR can be merged? This seems to keep happening to me whenever I try to select the checkbox in parent/descendant, and then it causes the table to rerender infinitely. This is blocking our workflow. Would love to get an estimation around this |
|
@MBilalShafi is it expected that in this demo, selecting the child rows cause the group to collapse? Screen.Recording.2024-11-04.at.14.56.14.mov |
|
@KenanYusuf It's a problem with the demo itself and not the Data Grid, here's some context on why it happens: #7771 (comment) Here's a fixed version: https://codesandbox.io/p/sandbox/mui-mui-x-x-data-grid-forked-cgpss2 |
|
It looks like this PR broke master: 
I noticed this on #15271. |
#15464) Co-authored-by: Bilal Shafi <[email protected]>
Fixes #15068 (Pro plan)
Fixes #15045 (Pro plan)
Fixes #15079 (Community plan)
Fixes #15217 (Pro plan)
Follow-up todos:
Add test coverage - will do so as a follow-up PR[DataGrid] Add test coverage for issues fixed in #15184 #15282