Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Fix right column group header border #15105

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

KenanYusuf
Copy link
Contributor

@KenanYusuf KenanYusuf commented Oct 24, 2024

@KenanYusuf KenanYusuf added component: data grid This is the name of the generic UI component, not the React module! feature: Column groups Related to the data grid Column groups feature bug 🐛 Something doesn't work design This is about UI or UX design, please involve a designer needs cherry-pick The PR should be cherry-picked to master after merge labels Oct 24, 2024
@mui-bot
Copy link

mui-bot commented Oct 24, 2024

Deploy preview: https://deploy-preview-15105--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 47ad2d3

@KenanYusuf KenanYusuf changed the title [DataGrid] Fix right column group header border [DataGrid] Fix right column group header right border Oct 24, 2024
@KenanYusuf
Copy link
Contributor Author

The argos diff is surprising 🤨

@KenanYusuf KenanYusuf changed the title [DataGrid] Fix right column group header right border [DataGrid] Fix right column group header border Oct 24, 2024
@flaviendelangle
Copy link
Member

@KenanYusuf I got the same on a Tree View PR 😬

@KenanYusuf KenanYusuf requested a review from a team October 24, 2024 15:30
@KenanYusuf KenanYusuf merged commit bc0674a into mui:master Oct 28, 2024
26 of 28 checks passed
@KenanYusuf KenanYusuf deleted the fix-column-group-header-border branch October 28, 2024 15:04
KenanYusuf added a commit to KenanYusuf/mui-x that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer feature: Column groups Related to the data grid Column groups feature needs cherry-pick The PR should be cherry-picked to master after merge
Projects
None yet
4 participants