-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Remove TDate
generics in favor of PickerValidDate
direct usage
#15001
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Co-authored-by: Lukas Tyla <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
@LukasTy one option would be to add the following code in one of the doc files: declare module '@mui/x-date-pickers/models' {
interface PickerValidDateLookup {
fakeDocAdapter: any;
}
} It would not impact Codesandbox / Stackblitz. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
a0f9d1a
to
ad4dbf4
Compare
ad4dbf4
to
1573e01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Epic work! 💯 🚀 🌔
Massive piece of destruction and cleanup. 👏
Leaving some non-blocking comments. 😉
Closes #14796
Side note: all
PickerValidDate | null
passed as a generic will be replaced with atrue
orfalse
onceTValue
is replaced byTIsRange
(phrase 2 of #14823).I will do the migration guide after the phase 2 of #14823 to have a finalized list of the breaking changes on the generics.
Changelog
Pickers
The
TDate
generic has been removed from all the types, interfaces, and variables of the@mui/x-date-pickers
and@mui/x-date-pickers-pro
packages.If you were passing your date object type as a generic to any element of one of those packages, you can remove it:
A follow-up release will add the full list of the impacted elements to the migration guide.