Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TreeView] Fix invalid test for items reordering #14665

Merged
merged 1 commit into from
Sep 25, 2024
Merged

[TreeView] Fix invalid test for items reordering #14665

merged 1 commit into from
Sep 25, 2024

Conversation

flaviendelangle
Copy link
Member

Extracted from #14210

The describe says the tests are testing isItemReorderable, not canMoveItemToNewPosition.

@flaviendelangle flaviendelangle self-assigned this Sep 19, 2024
@flaviendelangle flaviendelangle added the component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! label Sep 19, 2024
@flaviendelangle flaviendelangle marked this pull request as ready for review September 19, 2024 07:06
@flaviendelangle flaviendelangle mentioned this pull request Sep 19, 2024
Merged
18 tasks
@mui-bot
Copy link

mui-bot commented Sep 19, 2024

Deploy preview: https://deploy-preview-14665--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against ea9cf63

noraleonte
noraleonte approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@noraleonte noraleonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@flaviendelangle flaviendelangle merged commit 4e48c38 into mui:master Sep 25, 2024
19 of 20 checks passed
@flaviendelangle flaviendelangle deleted the items-reordering-test-issue branch September 25, 2024 14:27
arthurbalduini pushed a commit to arthurbalduini/mui-x that referenced this pull request Sep 30, 2024
@flaviendelangle
[TreeView] Fix invalid test for items reordering (mui#14665)
3450b45
This was referenced Nov 1, 2024
Open
Open
Open
@DMPatod DMPatod mentioned this pull request Nov 2, 2024
Open
@mbreadmachine mbreadmachine mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noraleonte noraleonte noraleonte approved these changes

@michelengelen michelengelen Awaiting requested review from michelengelen

Assignees

@flaviendelangle flaviendelangle

Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flaviendelangle @mui-bot @noraleonte