Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump React #14424

Closed
wants to merge 1 commit into from
Closed

Bump React #14424

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 1, 2024 •
edited
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/react (source) ^18.3.4 -> ^18.3.12 age adoption passing confidence
@types/react-dom (source) ^18.3.0 -> ^18.3.1 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Update of dependencies label Sep 1, 2024
@mui-bot
Copy link

mui-bot commented Sep 1, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-14424--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against fee2275

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 3, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 3, 2024
@LukasTy
Copy link
Member

LukasTy commented Sep 4, 2024

This line:

mui-x/packages/x-data-grid/src/components/cell/GridCell.tsx

Line 74 in abf7726

[x: string]: any; // TODO v7: remove this - it breaks type safety
causes all the props to be resolved as any after DefinitelyTyped/DefinitelyTyped#70361
WDYT @mui/xgrid, is there a way around it? 🤔

@LukasTy LukasTy added the on hold There is a blocker, we need to wait label Sep 4, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 5, 2024
@cherniavskii cherniavskii removed the on hold There is a blocker, we need to wait label Sep 5, 2024
cherniavskii
cherniavskii approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why some proptypes were removed and other were added 😅
But I don't think we should spend additional time on that, since the proptypes checks will be removed in React 19 anyway.

packages/x-data-grid-pro/src/tests/cellEditing.DataGridPro.test.tsx Outdated
@@ -344,7 +344,7 @@ describe('<DataGridPro /> - Cell editing', () => {
});

describe('stopCellEditMode', () => {
function CustomEditComponent({ hasFocus }: GridCellProps) {
function CustomEditComponent({ hasFocus }: GridRenderEditCellParams) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were using the wrong interface here 😅

packages/x-data-grid/src/components/GridRow.tsx Outdated
@@ -101,7 +101,6 @@ const GridRow = React.forwardRef<HTMLDivElement, GridRowProps>(function GridRow(
isLastVisible,
isNotVisible,
showBottomBorder,
focusedCell,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unused and not passed to the component

packages/x-data-grid/src/components/cell/GridCell.tsx Outdated
@@ -493,13 +496,6 @@ GridCell.propTypes = {
}),
gridHasFiller: PropTypes.bool.isRequired,
isNotVisible: PropTypes.bool.isRequired,
onClick: PropTypes.func,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why optional props were removed.

@cherniavskii cherniavskii requested a review from LukasTy September 5, 2024 19:33
LukasTy
LukasTy reviewed Sep 6, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT @cherniavskii?
I've made some other changes and stabilized GridToolbar components prop generation as it seemed "cursed" (used to generate proptypes on one run, then destroy on the other... 🙈 )

packages/x-data-grid/src/components/toolbar/GridToolbarExport.tsx Outdated
/**
* The props used for each slot inside.
* @default {}
*/
slotProps?: { button?: Partial<ButtonProps>; tooltip?: Partial<TooltipProps> };
[key: string]: any;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These entries in types seemed to be "ruining" proptypes script... 🙈
I've explicitly added the missing excelOptions.
WDYT?
As far as I can see—this is a slight BC like the cases with Cell and Row.
Docs examples had to be updated. 🙈
But, in the grand scheme—it's a bug fix as well... 🤷

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this breaking change seems to be more impactful, I'm not sure I'm willing to trade it for proper proptypes generation, especially given that even our own demos are impacted 🤔

packages/x-data-grid/src/components/toolbar/GridCsvExportMenuItem.tsx Outdated
);
}

GridCsvExportMenuItem.propTypes = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved these components to separate files in order to have stable proptypes generation (they are generated for all the files).
In the original place one of the components was missing proptypes... 🤷

packages/x-data-grid/src/components/cell/GridCell.tsx Outdated Show resolved Hide resolved
@LukasTy LukasTy requested a review from cherniavskii September 6, 2024 10:26
@cherniavskii cherniavskii self-assigned this Sep 6, 2024
@cherniavskii cherniavskii mentioned this pull request Sep 6, 2024
Open
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 11, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 1, 2024
@LukasTy LukasTy changed the title Bump @types/react to ^18.3.5 Bump @types/react to ^18.3.12 Nov 1, 2024
@renovate renovate bot changed the title Bump @types/react to ^18.3.12 Bump React Nov 3, 2024
@LukasTy LukasTy mentioned this pull request Nov 4, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 6, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 6, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 6, 2024
@renovate renovate bot enabled auto-merge (squash) November 6, 2024 17:44
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Nov 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 7, 2024
@LukasTy LukasTy disabled auto-merge November 7, 2024 10:23
@LukasTy LukasTy closed this Nov 7, 2024
@LukasTy LukasTy deleted the renovate/react branch November 7, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy left review comments

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

Assignees

@cherniavskii cherniavskii

Labels
dependencies Update of dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mui-bot @LukasTy @cherniavskii