Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] set default variant to 'standard' in GridFilterInputMultipleValue #13129

Conversation

tarunrajput
Copy link
Contributor

@tarunrajput tarunrajput commented May 14, 2024

Fixes: #13104

Set standard as default value input variant for GridFilterInputMultipleValue to match with other filter panel fields

Preview: https://deploy-preview-13129--material-ui-x.netlify.app/x/react-data-grid/filtering/

@tarunrajput tarunrajput changed the title fix(Data Grid): set default variant to 'standard' in GridFilterInputMultipleValue [Data Grid] set default variant to 'standard' in GridFilterInputMultipleValue May 14, 2024
@zannager zannager added the component: data grid This is the name of the generic UI component, not the React module! label May 15, 2024
@michelengelen michelengelen changed the title [Data Grid] set default variant to 'standard' in GridFilterInputMultipleValue [DataGrid] set default variant to 'standard' in GridFilterInputMultipleValue Jun 10, 2024
@michelengelen michelengelen enabled auto-merge (squash) June 10, 2024 09:33
@michelengelen michelengelen added the enhancement This is not a bug, nor a new feature label Jun 10, 2024
@michelengelen michelengelen changed the title [DataGrid] set default variant to 'standard' in GridFilterInputMultipleValue [DataGrid] set default variant to 'standard' in GridFilterInputMultipleValue Jun 10, 2024
@michelengelen
Copy link
Member

Sry for the late review ... LGTM! :shipit:

@mui-bot
Copy link

mui-bot commented Jul 10, 2024

Deploy preview: https://deploy-preview-13129--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against c509117

@michelengelen michelengelen merged commit e9dbcc1 into mui:master Jul 10, 2024
15 checks passed
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data grid] GridToolbar filter 'is any of' selection is showing outlined input instead of regular input
5 participants