[charts] Fix area order when overlapping #13121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
added
bug 🐛
|
Deploy preview: https://deploy-preview-13121--material-ui-x.netlify.app/ |
JCQuintas
approved these changes
May 14, 2024
Co-authored-by: Jose C Quintas Jr <[email protected]> Signed-off-by: Alexandre Fauquette <[email protected]>
arthurbalduini
pushed a commit
to arthurbalduini/mui-x
that referenced
this pull request
May 23, 2024
Signed-off-by: Alexandre Fauquette <[email protected]> Co-authored-by: Jose C Quintas Jr <[email protected]>
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
Signed-off-by: Alexandre Fauquette <[email protected]> Co-authored-by: Jose C Quintas Jr <[email protected]>
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Signed-off-by: Alexandre Fauquette <[email protected]> Co-authored-by: Jose C Quintas Jr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13067
I would still discourage the use of overlapping areas except for very specific edge case (such the one in the issue) 🙈
With no structure
With guarantee some series are always smaller than others
I introduced this
reversewhen creating the animation, otherwise you get a weird state with the line and the area not in sync, just because the area on top of you is overlapping (the time it finishes its animation too)This fix applies the reverse on staking groups instead of all series.