[DataGrid] Fix ElementType
usage
#12479
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mui/material-ui#40427 for the data grid
In
GridPanel
, you can still see generics being passed toReact.ElementType
, but this was solved on the Core side in mui/material-ui#41500Testing
It's hard to test because it requires a different version of
@types/react
than we use in our monorepo.I've created a branch in https://github.com/cherniavskii/cra-data-grid-test/tree/react17
Before:
After: