-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Improve slots definitions for charts #12408
Conversation
Deploy preview: https://deploy-preview-12408--material-ui-x.netlify.app/ Updated pages: |
This is really helpful! Sorry I'm just a random person on the internet but you happened to push this right as I was trying to use slots for a pie chart. I have a custom tooltip - wondering how I can make that tooltip have an arrow? I think I can figure it out somehow but I am not finding it well documented |
@kelseywarshawsky What interest you is here: https://github.com/mui/mui-x/blob/master/packages/x-charts/src/ChartsTooltip/ChartsTooltip.tsx/#L143-L161 Basically if you use the For example function MyCustomChartsTooltip({open, placement, anchorEl}) {
return <Popper open={open} placement={placement} anchorEl={anchorEl}>
<ArrowElement placement={placement} anchorEl={anchorEl} />
{children}
</Popper>
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix #12268
Fix #10352
yarn proptypes & yarn docs:api