v7.0.0-beta.6 #12375
Merged
v7.0.0-beta.6 #12375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
requested review from
joserodolfofreitas,
romgrk,
DanailH,
MBilalShafi,
cherniavskii,
bharatkashyap,
michelengelen,
alexfauquette and
noraleonte
flaviendelangle
commented
Mar 8, 2024
| @@ -246,7 +246,7 @@ Same changes as in \`@mui/x-data-grid-pro@__VERSION__\`${ | |||
| dataGridPremiumCommits.length > 0 ? ', plus:\n' : '.' | |||
| } | |||
| ${logChangelogSection(dataGridPremiumCommits)}${dataGridPremiumCommits.length > 0 ? '\n' : ''} | |||
| ### Date Pickers | |||
| ### Date and Time Pickers | |||
There was a problem hiding this comment.
We try to use the same wording everywhere, I'm surprised that this occurrence was not spotted before
|
Deploy preview: https://deploy-preview-12375--material-ui-x.netlify.app/ |
LukasTy
reviewed
Mar 8, 2024
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@mui/x-license", | |||
| "version": "7.0.0-beta.2", | |||
| "version": "7.0.0-beta.6", | |||
There was a problem hiding this comment.
I would have voted for consistency with previous approaches before a consensus is reached, but if you decided otherwise, so be it. 👌
alexfauquette
approved these changes
Mar 8, 2024
Co-authored-by: Lukas <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>
Co-authored-by: Lukas <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>
flaviendelangle
force-pushed
the
v7.0.0-beta.6
branch
from
2cee204 to
6f6457d
Compare
Co-authored-by: Michel Engelen <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>
LukasTy
approved these changes
Mar 8, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Signed-off-by: Flavien DELANGLE <[email protected]> Co-authored-by: Lukas <[email protected]> Co-authored-by: Michel Engelen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing to release on
masterthis weekWhich packages are released
We had a chat last week with @cherniavskii, @joserodolfofreitas and @DanailH and it seems that we don't all agree about which packages should be released based on the changes done during the week and with which version.
So we decided that, until we reached to an agreement, we would just follow what Lerna suggests.