Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Fix double border under header #12349

Merged
merged 5 commits into from
Mar 6, 2024
Merged

[DataGrid] Fix double border under header #12349

merged 5 commits into from
Mar 6, 2024

Conversation

joespeargresham
Copy link
Contributor

Fixes #12334

@joespeargresham joespeargresham marked this pull request as draft March 6, 2024 12:35
@mui-bot
Copy link

mui-bot commented Mar 6, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-12349--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against a79ac4a

@joespeargresham joespeargresham marked this pull request as ready for review March 6, 2024 12:38
@romgrk romgrk added the component: data grid This is the name of the generic UI component, not the React module! label Mar 6, 2024
@romgrk
Copy link
Contributor

romgrk commented Mar 6, 2024 •
edited
Loading

I think we'll need to find a different change to fix this, the border is required for the cases where the rows don't fill the full space:

current previous
image image

Maybe instead we can skip rendering the filler in GridVirtualScroller when there are no rows?

@joespeargresham joespeargresham marked this pull request as draft March 6, 2024 14:16
@joespeargresham
Copy link
Contributor Author

joespeargresham commented Mar 6, 2024 •
edited
Loading

@romgrk Thanks - I'll try that now.

@joespeargresham
Copy link
Contributor Author

That seems to have worked

image
image

@joespeargresham joespeargresham marked this pull request as ready for review March 6, 2024 14:41
@romgrk romgrk enabled auto-merge (squash) March 6, 2024 15:02
@romgrk romgrk merged commit 2119870 into mui:next Mar 6, 2024
15 checks passed
@romgrk
Copy link
Contributor

romgrk commented Mar 6, 2024

Thanks for the PR 👍

@joespeargresham joespeargresham deleted the fix-grid-header-border branch March 7, 2024 10:06
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@joespeargresham @romgrk @thomasmoon
[DataGrid] Fix double border under header (mui#12349)
abe5735 
Signed-off-by: Joseph Spear <[email protected]>
Co-authored-by: Rom Grk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romgrk romgrk romgrk approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Double border under header row when no rows in v7 (beta 4)
3 participants
@joespeargresham @mui-bot @romgrk