[DataGrid] Fix page count selector #12343
Conversation
|
Deploy preview: https://deploy-preview-12343--material-ui-x.netlify.app/ |
| apiRef.current.setState((state) => ({ | ||
| ...state, | ||
| props: { | ||
| rowCount: props.rowCount, |
There was a problem hiding this comment.
I think we have to make rowCount part of the state for the server-side data source (a controlled state) as we need to update it internally based on different factors, I wanted to make it part of the pagination state, i.e. pagination.rowCount which should fix the page count selector as well.
PR / file where I tried to do it.
Would it be useful to still keep this prop in state (as a prop)?
There was a problem hiding this comment.
Ah ok. Seems like it would make the selector work. Do you want to handle this issue in your PR or should we merge this as it is and you pick it up in your PR?
There was a problem hiding this comment.
Whatever you prefer, ideally it'd be better to do it in my PR (I'll most likely extract the independent changes in separate PRs which will allow to deliver them sooner)
We could keep this PR open though, if we have another prop to make part of state we can update the PR and merge it.
There was a problem hiding this comment.
I'll let you handle the issue then. I'll close, we can reopen anytime.
zannager
added
the
component: data grid
Closes #8450
Add one prop in the state so we can use it in the selector.
Before: https://codesandbox.io/s/brave-goldberg-3lve8e?file=/demo.tsx