-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Allow to control the grid density #12332
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MBilalShafi
added
component: data grid
This is the name of the generic UI component, not the React module!
customization: logic
Logic customizability
enhancement
This is not a bug, nor a new feature
labels
Mar 5, 2024
Co-authored-by: Flavien DELANGLE <[email protected]> Signed-off-by: Bilal Shafi <[email protected]>
packages/x-data-grid/src/hooks/features/density/useGridDensity.tsx
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Mar 12, 2024
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Update: I may have to rework this to make it a proper controlled model |
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Mar 18, 2024
MBilalShafi
changed the title
[DataGrid] Add event callback on density change
[DataGrid] Allow to control the grid density
Mar 19, 2024
cherniavskii
approved these changes
Mar 19, 2024
docs/data/migration/migration-data-grid-v6/migration-data-grid-v6.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Cherniavskii <[email protected]> Signed-off-by: Bilal Shafi <[email protected]>
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Signed-off-by: Bilal Shafi <[email protected]> Co-authored-by: Flavien DELANGLE <[email protected]> Co-authored-by: Andrew Cherniavskii <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
component: data grid
This is the name of the generic UI component, not the React module!
customization: logic
Logic customizability
enhancement
This is not a bug, nor a new feature
v7.x
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5647
Changelog
Breaking changes
density
is a controlled prop now, if you were previously passing thedensity
prop to the Data Grid, you will need to do one of the following:Move it to the
initialState.density
to initialize it.Move it to the state and use
onDensityChange
callback to update thedensity
prop accordingly for it to work as expected.gridDensityValueSelector
was removed, use thegridDensitySelector
instead.