[data-grid] Fix crashing of demos on rating change #12315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
bug 🐛
sai6855
changed the title
|
Deploy preview: https://deploy-preview-12315--material-ui-x.netlify.app/ |
sai6855
commented
Mar 4, 2024
Comment on lines
18
to
22
| if (value !== 0) { | ||
| element.querySelector<HTMLElement>(`input[value="${value}"]`)!.focus(); | ||
| } else { | ||
| element.querySelector<HTMLElement>(`input[value=""]`)!.focus(); | ||
| } |
There was a problem hiding this comment.
when ever user goes one up on 5 and down on 1, value will be 0.
As there are no inputs with value="0" demos were crashing on focusing non existing inputs. So focusing on input with no value (input[value='']) whenever value=0 seems to fix the issue.
1 task
romgrk
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes 2nd bug mentioned in this comment #12199 (comment)
PR for 1st point --> #12335
preview: https://deploy-preview-12315--material-ui-x.netlify.app/x/react-data-grid/filtering/quick-filter/