Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fields] Fix tabIndex on accessible field DOM structure #12311

Merged
merged 1 commit into from
Mar 8, 2024
Merged

[fields] Fix tabIndex on accessible field DOM structure #12311

merged 1 commit into from
Mar 8, 2024

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Mar 4, 2024 •
edited by LukasTy
Loading

Changes

  • Pressing Tab when selecting a section of the field will jump to the next tabbable component outside of this field (we no longer put tabIndex={0} on every single section
  • Pressing Shift + Tab while selecting the 1st section of a field field correctly moves the focus to the previous tabbable component outside of the field, not to the field container.

@flaviendelangle flaviendelangle added bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! labels Mar 4, 2024
@flaviendelangle flaviendelangle self-assigned this Mar 4, 2024
@flaviendelangle flaviendelangle marked this pull request as draft March 4, 2024 08:18
@mui-bot
Copy link

mui-bot commented Mar 4, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-12311--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 6f1a9d9

@flaviendelangle flaviendelangle changed the title [fields] Fix tabIndex on accessible field DOM structure [fields] Fix tabIndex on accessible field DOM structure Mar 4, 2024
@flaviendelangle flaviendelangle marked this pull request as ready for review March 4, 2024 12:49
@flaviendelangle flaviendelangle requested a review from LukasTy March 4, 2024 12:49
LukasTy
LukasTy approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 💙 💯 🚀

@flaviendelangle flaviendelangle merged commit df31301 into mui:next Mar 8, 2024
17 checks passed
@flaviendelangle flaviendelangle deleted the focus-field-v7 branch March 8, 2024 15:38
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@flaviendelangle @thomasmoon
[fields] Fix tabIndex on accessible field DOM structure (mui#12311)
8739b12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

Assignees

@flaviendelangle flaviendelangle

Labels
bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flaviendelangle @mui-bot @LukasTy