Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Rename gridClasses to dataGridClasses #12253

Closed
wants to merge 2 commits into from
Closed

[DataGrid] Rename gridClasses to dataGridClasses #12253

wants to merge 2 commits into from

Conversation

MBilalShafi
Copy link
Member

Closes #12061

Changes:

  • Rename the variable and occurances
  • Add to migration guide
  • Add codemod

Changelog

Breaking changes

  • The export gridClasses has been renamed to dataGridClasses.
  • The related types GridClassKey and GridClasses have also been renamed to DataGridClassKey and DataGridClasses respectively.

@MBilalShafi MBilalShafi added breaking change component: data grid This is the name of the generic UI component, not the React module! v7.x labels Feb 28, 2024
@mui-bot
Copy link

mui-bot commented Feb 28, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-12253--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against 9e9bde2

@flaviendelangle
Copy link
Member

I saw this Notion page recently, don't know how it impacts this PR: https://www.notion.so/mui-org/mui-x-Shorten-Data-Grid-to-Grid-166bffd69b8a47ca9a4f2f45eeb5e4a6

@romgrk
Copy link
Contributor

romgrk commented Feb 28, 2024

I don't love that it becomes more verbose for our internal code, and inconsistent considering we're using the grid prefix for all our variables/functions/filenames. I wonder if we shouldn't make the change only to the exported symbol and keep the rest as is.

@romgrk
Copy link
Contributor

romgrk commented Feb 28, 2024

Just read the notion doc, I love that change. Maybe we should make a decision on the shaping doc first, then follow-up with this PR if it still applies.

@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! PR: out-of-date The pull request has merge conflicts and can't be merged v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Rename gridClasses to dataGridClasses
4 participants
@MBilalShafi @mui-bot @flaviendelangle @romgrk