Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Remove legacy editing API event: rowEditCommit #12073

Merged
merged 3 commits into from
Feb 15, 2024
Merged

[DataGrid] Remove legacy editing API event: rowEditCommit #12073

merged 3 commits into from
Feb 15, 2024

Conversation

MBilalShafi
Copy link
Member

@MBilalShafi MBilalShafi commented Feb 15, 2024 •
edited
Loading

Closes #12071

Changelog

Breaking changes

  • The rowEditCommit event and the related prop onRowEditCommit was removed. The processRowUpdate prop can be used in place.

@MBilalShafi MBilalShafi added breaking change component: data grid This is the name of the generic UI component, not the React module! feature: Editing Related to the data grid Editing feature v7.x needs cherry-pick The PR should be cherry-picked to master after merge labels Feb 15, 2024
@mui-bot
Copy link

mui-bot commented Feb 15, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-12073--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against e32024b

@MBilalShafi MBilalShafi marked this pull request as ready for review February 15, 2024 15:56
@MBilalShafi MBilalShafi requested a review from romgrk February 15, 2024 15:56
@MBilalShafi MBilalShafi enabled auto-merge (squash) February 15, 2024 16:18
@MBilalShafi MBilalShafi merged commit b797892 into mui:next Feb 15, 2024
15 checks passed
@MBilalShafi MBilalShafi mentioned this pull request Feb 16, 2024
Merged
@MBilalShafi MBilalShafi deleted the remove-rowEditCommit branch February 16, 2024 05:57
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@MBilalShafi @thomasmoon
[DataGrid] Remove legacy editing API event: rowEditCommit (mui#12073)
cb6a4d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romgrk romgrk romgrk approved these changes

Assignees
No one assigned
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! feature: Editing Related to the data grid Editing feature needs cherry-pick The PR should be cherry-picked to master after merge v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Remove the unused legacy editing API event rowEditCommit
3 participants
@MBilalShafi @mui-bot @romgrk