-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump monorepo #12055
bump monorepo #12055
Conversation
alexfauquette
commented
Feb 14, 2024
- I have followed (at least) the PR section of the contributing guide.
Deploy preview: https://deploy-preview-12055--material-ui-x.netlify.app/ |
@alexfauquette if you can update to include mui/material-ui#41033 🙏 |
yarn.lock
Outdated
available-typed-arrays "^1.0.5" | ||
call-bind "^1.0.5" | ||
es-set-tostringtag "^2.0.1" | ||
es-abstract@^1.22.1, es-abstract@^1.22.3: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: Are all these additional bumps related to the monorepo bump? 🤔
At first sight, it seems like a "job" for "lock file maintenance". 🙈 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LukasTy I just run yarn upgrade @mui/monorepo
and yarn deduplicate
and no clue about why those stuff get updated. All I know is it breaks the CI 🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈
Have you tried only updating what's necessary?
Try deleting the monorepo
entry in the lock file and running yarn
. 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work 🙈🤯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. 👏
@flaviendelangle Does it matter if it is included in the monorepo? 🤔 |
Oh right I forgot the new architecture |