Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump monorepo #12055

Merged
merged 1 commit into from
Feb 14, 2024
Merged

bump monorepo #12055

merged 1 commit into from
Feb 14, 2024

Conversation

alexfauquette
Copy link
Member

@mui-bot
Copy link

mui-bot commented Feb 14, 2024

Deploy preview: https://deploy-preview-12055--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 609dbb6

@flaviendelangle
Copy link
Member

@alexfauquette if you can update to include mui/material-ui#41033 🙏

yarn.lock Outdated
available-typed-arrays "^1.0.5"
call-bind "^1.0.5"
es-set-tostringtag "^2.0.1"
es-abstract@^1.22.1, es-abstract@^1.22.3:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: Are all these additional bumps related to the monorepo bump? 🤔
At first sight, it seems like a "job" for "lock file maintenance". 🙈 🤷

Copy link
Member Author

@alexfauquette alexfauquette Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LukasTy I just run yarn upgrade @mui/monorepo and yarn deduplicate and no clue about why those stuff get updated. All I know is it breaks the CI 🙈

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈
Have you tried only updating what's necessary?
Try deleting the monorepo entry in the lock file and running yarn. 🤷

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work 🙈🤯

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. 👏

@LukasTy
Copy link
Member

LukasTy commented Feb 14, 2024

if you can update to include mui/material-ui#41033 🙏

@flaviendelangle Does it matter if it is included in the monorepo? 🤔
It is a separately published package as far as I can see. 🤷

@flaviendelangle
Copy link
Member

flaviendelangle commented Feb 14, 2024

Oh right I forgot the new architecture

@LukasTy LukasTy added the core Infrastructure work going on behind the scenes label Feb 14, 2024
@alexfauquette alexfauquette marked this pull request as ready for review February 14, 2024 15:10
@alexfauquette alexfauquette merged commit fd92ca6 into mui:next Feb 14, 2024
18 checks passed
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants