Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7.0.0-beta.2 #12012

Closed
wants to merge 7 commits into from
Closed

v7.0.0-beta.2 #12012

wants to merge 7 commits into from

Conversation

DanailH
Copy link
Member

@DanailH DanailH commented Feb 9, 2024

No description provided.

@DanailH DanailH added the release We are shipping :D label Feb 9, 2024
@DanailH DanailH requested a review from a team February 9, 2024 13:39
@DanailH DanailH self-assigned this Feb 9, 2024
@DanailH DanailH changed the title v7.0.0-beta.1 v7.0.0-beta.2 Feb 9, 2024
@mui-bot
Copy link

mui-bot commented Feb 9, 2024

Deploy preview: https://deploy-preview-12012--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 4a515f6

@DanailH DanailH removed the request for review from a team February 9, 2024 13:49
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
- [core] Integrate changes from Core's #40842 (#11801) @michaldudak
- [core] Move next config to ESM (#11882) @Janpot
- [core] auto-message on closed issues (#11805) @michelengelen
- [core] Rename `@mui/x-license-pro` to `@mui/x-license` (#11938) @cherniavskii
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this specific scenario it's weird to have a breaking change in [core]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do you think it should be? It impacts both Data Grid and Pickers and it's highlighted as a breaking change at the very top of the changelog

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speeking in a new H3 I guess

### License / `@mui/[email protected]`

Copy link
Member

@flaviendelangle flaviendelangle Feb 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understand, [core] is only for elements that don't impact our users, it's an invitation to skip the section

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, for - [core] Deprecate LicenseInfo re-exports (#11956) @cherniavskii one could consider duplicating it in data-grid-pro and pickers-pro

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have the discussion in the other PR but I don't think it matters that much in this case since it's listed as a breaking change but I can do a separate section as @flaviendelangle suggested.

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@DanailH DanailH requested a review from a team February 9, 2024 13:52
@@ -1,6 +1,6 @@
{
"name": "@mui/x-license",
"version": "7.0.0-beta.0",
"version": "7.0.0-beta.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "7.0.0-beta.1",
"version": "7.0.0-beta.2",

Sync with pickers and data grid version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was already out of sync. The current latest version is beta.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was out of sync because there were no changes to release.
But since we release it now, I think we should sync it with the "main" version.

DanailH and others added 4 commits February 9, 2024 15:57
Co-authored-by: Flavien DELANGLE <[email protected]>
Co-authored-by: Lukas <[email protected]>
Signed-off-by: Danail Hadjiatanasov <[email protected]>
Co-authored-by: Bilal Shafi <[email protected]>
Signed-off-by: Danail Hadjiatanasov <[email protected]>
@DanailH DanailH closed this Feb 9, 2024
@DanailH
Copy link
Member Author

DanailH commented Feb 9, 2024

I messed up the branch. I'll open a new PR

@oliviertassinari oliviertassinari deleted the new/7.0.0-beta.1 branch August 25, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release We are shipping :D
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants