-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v7.0.0-beta.2 #12012
v7.0.0-beta.2 #12012
Conversation
Deploy preview: https://deploy-preview-12012--material-ui-x.netlify.app/ |
- [core] Integrate changes from Core's #40842 (#11801) @michaldudak | ||
- [core] Move next config to ESM (#11882) @Janpot | ||
- [core] auto-message on closed issues (#11805) @michelengelen | ||
- [core] Rename `@mui/x-license-pro` to `@mui/x-license` (#11938) @cherniavskii |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this specific scenario it's weird to have a breaking change in [core]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do you think it should be? It impacts both Data Grid and Pickers and it's highlighted as a breaking change at the very top of the changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strictly speeking in a new H3 I guess
### License / `@mui/[email protected]`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I understand, [core]
is only for elements that don't impact our users, it's an invitation to skip the section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, for - [core] Deprecate
LicenseInfo re-exports (#11956) @cherniavskii
one could consider duplicating it in data-grid-pro
and pickers-pro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's have the discussion in the other PR but I don't think it matters that much in this case since it's listed as a breaking change but I can do a separate section as @flaviendelangle suggested.
7a37db1
to
ee1eadd
Compare
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@mui/x-license", | |||
"version": "7.0.0-beta.0", | |||
"version": "7.0.0-beta.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"version": "7.0.0-beta.1", | |
"version": "7.0.0-beta.2", |
Sync with pickers and data grid version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was already out of sync. The current latest version is beta.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it was out of sync because there were no changes to release.
But since we release it now, I think we should sync it with the "main" version.
Co-authored-by: Flavien DELANGLE <[email protected]> Co-authored-by: Lukas <[email protected]> Signed-off-by: Danail Hadjiatanasov <[email protected]>
Co-authored-by: Bilal Shafi <[email protected]> Signed-off-by: Danail Hadjiatanasov <[email protected]>
…new/7.0.0-beta.1
I messed up the branch. I'll open a new PR |
No description provided.