-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add a note about AdapterDateFnsV3
on the Getting Started page
#11985
Conversation
@@ -43,7 +43,7 @@ For `date-fns`, import the locale and pass it to `LocalizationProvider`: | |||
:::info | |||
Both `date-fns` major versions (v2.x and v3.x) are supported. | |||
|
|||
A single adapter can not work for both `date-fns` v2.x and v3.x, because the way functions are exported has been changed in v3.x. | |||
A single adapter cannot work for both `date-fns` v2.x and v3.x, because the way functions are exported has been changed in v3.x. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make a PR to remove all the "can't" and "can not" from our doc 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. 👌
Deploy preview: https://deploy-preview-11985--material-ui-x.netlify.app/ Updated pages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement! 👍
Co-authored-by: Lukas <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>
AdapterDateFnsV3
on the Getting Started page
#11985) Signed-off-by: Flavien DELANGLE <[email protected]> Co-authored-by: Lukas <[email protected]>
mui#11985) Signed-off-by: Flavien DELANGLE <[email protected]> Co-authored-by: Lukas <[email protected]>
Not the prettiest code 😬
But I think it will reduce the amount of people trying to use
AdapterDateFns
with the latest date-fns releases