Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add a note about AdapterDateFnsV3 on the Getting Started page #11985

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

flaviendelangle
Copy link
Member

Not the prettiest code 😬
But I think it will reduce the amount of people trying to use AdapterDateFns with the latest date-fns releases

@flaviendelangle flaviendelangle self-assigned this Feb 8, 2024
@flaviendelangle flaviendelangle added docs Improvements or additions to the documentation component: pickers This is the name of the generic UI component, not the React module! labels Feb 8, 2024
@@ -43,7 +43,7 @@ For `date-fns`, import the locale and pass it to `LocalizationProvider`:
:::info
Both `date-fns` major versions (v2.x and v3.x) are supported.

A single adapter can not work for both `date-fns` v2.x and v3.x, because the way functions are exported has been changed in v3.x.
A single adapter cannot work for both `date-fns` v2.x and v3.x, because the way functions are exported has been changed in v3.x.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make a PR to remove all the "can't" and "can not" from our doc 😆

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. 👌

@mui-bot
Copy link

mui-bot commented Feb 8, 2024

@flaviendelangle flaviendelangle marked this pull request as ready for review February 8, 2024 08:22
@flaviendelangle flaviendelangle added the needs cherry-pick The PR should be cherry-picked to master after merge label Feb 8, 2024
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! 👍

@flaviendelangle flaviendelangle changed the title [docs] Add a note about AdapterDateFnsV3 on Getting Started page [docs] Add a note about AdapterDateFnsV3 on the Getting Started page Feb 8, 2024
@flaviendelangle flaviendelangle merged commit 09fc48c into mui:next Feb 8, 2024
17 checks passed
@flaviendelangle flaviendelangle deleted the date-fns-v3-doc branch February 8, 2024 09:25
github-actions bot pushed a commit that referenced this pull request Feb 8, 2024
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation needs cherry-pick The PR should be cherry-picked to master after merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants