Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Fix failing test_static on the next branch #11977

Merged
merged 1 commit into from
Feb 7, 2024
Merged

[core] Fix failing test_static on the next branch #11977

merged 1 commit into from
Feb 7, 2024

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii added the core Infrastructure work going on behind the scenes label Feb 7, 2024
@cherniavskii cherniavskii requested a review from a team February 7, 2024 13:05
LukasTy
LukasTy approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👌
This looks like an issue that is also relevant on master. 🙈
There it links to a non-existent section.

@mui-bot
Copy link

mui-bot commented Feb 7, 2024

Deploy preview: https://deploy-preview-11977--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against a6d7cc9

@cherniavskii
Copy link
Member Author

This looks like an issue that is also relevant on master.

It looks OK on master.
Here's the link:

mui-x/docs/data/introduction/support/support.md

Line 36 in 8f706fa

- [Tree View](/x/react-tree-view/#basic-tree-view)

And here's the section:

mui-x/docs/data/tree-view/overview/overview.md

Line 17 in 8f706fa

## Basic tree view

@cherniavskii cherniavskii merged commit 3a3263b into mui:next Feb 7, 2024
18 checks passed
@cherniavskii cherniavskii deleted the fix-test_static-on-next branch February 7, 2024 13:45
@LukasTy
Copy link
Member

LukasTy commented Feb 7, 2024

It looks OK on master. Here's the link:

Sorry, my bad. 🙈
I only checked the docs and not the actual master. 🤦

thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@cherniavskii @thomasmoon
[core] Fix failing test_static on the next branch (mui#11977)
a74b1e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cherniavskii @mui-bot @LukasTy