-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[license] Rename @mui/x-license-pro
to @mui/x-license
#11938
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 👏
@@ -31,6 +35,22 @@ To have the option of using the latest API from `@mui/material`, the package pee | |||
It is a change in minor version only, so it should not cause any breaking changes. | |||
Please update your `@mui/material` package to this or a newer version. | |||
|
|||
## Update the license package | |||
|
|||
If you're using the commerical versions of the Data Grid ([Pro](/x/introduction/licensing/#pro-plan) and [Premium](/x/introduction/licensing/#premium-plan) plans), you need to update the license package to the latest version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure about this? 🤔
The license package is a direct dependency of the commercial packages, the latest version will be downloaded if they are using the latest package version. 🤔
If we are referring to cases, where people are adding this dependency due to their package manager behavior, then maybe can make this section optional and move it below the import update, which is a clear BC for everyone? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My assumption here was that if they import from the package, it's very likely they have it in their dependencies as well.
But good point, the import path update is more important here 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌 💯
docs/data/migration/migration-data-grid-v6/migration-data-grid-v6.md
Outdated
Show resolved
Hide resolved
docs/data/migration/migration-pickers-v6/migration-pickers-v6.md
Outdated
Show resolved
Hide resolved
docs/data/migration/migration-pickers-v6/migration-pickers-v6.md
Outdated
Show resolved
Hide resolved
This closes #4250 |
Deprecation message added to the old npm package name: https://www.npmjs.com/package/@mui/x-license-pro This should help a bit developers during their migration, at the expense of degrading a bit the DX for folks who don't plan to upgrade. MUI X v7 was released 6 months ago, it's plenty of time. |
Currently,
@mui/x-license-pro
is used for Pro and Premium packages.This is confusing, so I'm taking the opportunity to make this change in v7 beta.
Close #4250
TODO:
Changelog
Breaking changes