[pickers] Avoid relying on locale in Luxon isWithinRange method
#11936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasTy
added
plan: Pro
LukasTy
added
the
needs cherry-pick
|
Deploy preview: https://deploy-preview-11936--material-ui-x.netlify.app/ |
|
|
||
| describe('isWithinRange functionality', () => { | ||
| const adapter = new AdapterLuxon({ locale: 'en-US' }); | ||
| it('should be equal with values in different locale', () => { |
There was a problem hiding this comment.
If possible, it would be great to move the test inside describeGregorianAdapter (there is a describe for isWithinRange).
That way we make sure that all adapters are coherent on this behavior.
We have a adapterFr object that is using the french locale so we should be able to use it to create the two dates and then use adapter to run isWithingRange with an en-US locale.
If I'm missing something and there is a technical limitation preventing us from doing it, it's of course not a deal breaker 👌
There was a problem hiding this comment.
Thanks for a great suggestion! 🙏
Moved the test and tests it's reliability. 😉
| @@ -324,8 +324,8 @@ export class AdapterLuxon implements MuiPickersAdapter<DateTime, string> { | |||
|
|
|||
| public isWithinRange = (value: DateTime, [start, end]: [DateTime, DateTime]) => { | |||
| return ( | |||
| value.equals(start) || | |||
| value.equals(end) || | |||
| this.isEqual(value, start) || | |||
flaviendelangle
approved these changes
Feb 5, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11622
We used Luxon API for comparing equality, but it also includes some metadata in comparison (like locale the date was created it).
With this change, we are only going to compare the difference in time.