Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Add 'removeAllFilterItems' as a reason of onFilterModelChange callback #11911

Merged
merged 1 commit into from
Feb 7, 2024
Merged

[DataGrid] Add 'removeAllFilterItems' as a reason of onFilterModelChange callback #11911

merged 1 commit into from
Feb 7, 2024

Conversation

shaharyar-shamshi
Copy link
Contributor

@shaharyar-shamshi shaharyar-shamshi commented Feb 4, 2024 •
edited by oliviertassinari
Loading

Fix #11907

@mui-bot
Copy link

mui-bot commented Feb 4, 2024

Deploy preview: https://deploy-preview-11911--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 58883e7

@oliviertassinari oliviertassinari added component: data grid This is the name of the generic UI component, not the React module! feature: Filtering Related to the data grid Filtering feature bug 🐛 Something doesn't work labels Feb 4, 2024
@oliviertassinari oliviertassinari changed the title Added removeAllFilterItems as the valid option for the reason of onFilterModelChange [data grid] Add removeAllFilterItems as the valid option for the reason of onFilterModelChange Feb 4, 2024
@michelengelen michelengelen changed the title [data grid] Add removeAllFilterItems as the valid option for the reason of onFilterModelChange [data grid] Add removeAllFilterItems as an option for the reason of onFilterModelChange Feb 6, 2024
@MBilalShafi MBilalShafi changed the title [data grid] Add removeAllFilterItems as an option for the reason of onFilterModelChange [DataGrid] Add 'removeAllFilterItems' as a reason of onFilterModelChange Feb 6, 2024
@MBilalShafi MBilalShafi changed the title [DataGrid] Add 'removeAllFilterItems' as a reason of onFilterModelChange [DataGrid] Add 'removeAllFilterItems' as a reason of onFilterModelChange callback Feb 6, 2024
MBilalShafi
MBilalShafi approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution. 🙏

@MBilalShafi MBilalShafi merged commit 91c8e58 into mui:next Feb 7, 2024
19 of 20 checks passed
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@shaharyar-shamshi @thomasmoon
[DataGrid] Add 'removeAllFilterItems' as a reason of `onFilterModelCh…
860cd1f 
…ange` callback (mui#11911)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBilalShafi MBilalShafi MBilalShafi approved these changes

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Filtering Related to the data grid Filtering feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] FilterToolbar RemovaAll button does not have a reason onFilterModelChange
4 participants
@shaharyar-shamshi @mui-bot @MBilalShafi @oliviertassinari